linux-kernel - Re: [PATCH] x86: include prototype for no

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080213104227.GC32241@elte.hu>
Date:	Wed, 13 Feb 2008 11:42:27 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Harvey Harrison <harvey.harrison@...il.com>
Cc:	Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] x86: include prototype for no_broadcast in
	mach-default/setup.c


* Harvey Harrison <harvey.harrison@...il.com> wrote:

> Fixes sparse warning:
> arch/x86/mach-default/setup.c:19:5: warning: symbol 'no_broadcast' was not declared. Should it be static?

hm, this patch causes a build failure:

In file included from arch/x86/mach-default/setup.c:13:
include/asm/mach-default/mach_ipi.h: In function '__local_send_IPI_allbutself':
include/asm/mach-default/mach_ipi.h:25: error: 'APIC_DEST_ALLBUT' undeclared (first use in this function)
include/asm/mach-default/mach_ipi.h:25: error: (Each undeclared identifier is reported only once
include/asm/mach-default/mach_ipi.h:25: error: for each function it appears in.)include/asm/mach-default/mach_ipi.h: In function '__local_send_IPI_all':
include/asm/mach-default/mach_ipi.h:33: error: 'APIC_DEST_ALLINC' undeclared (first use in this function)

config attached. The include file dependencies in this area are a bit of 
a mess - perhaps they need some cleanups?

	Ingo

View attachment "config" of type "text/plain" (46367 bytes)