[<prev] [next>] [day] [month] [year] [list]
Message-ID: <47B2CDD1.1070406@tiscali.nl>
Date: Wed, 13 Feb 2008 12:00:33 +0100
From: Roel Kluin <12o3l@...cali.nl>
To: thomas@...ischhofer.net, lkml <linux-kernel@...r.kernel.org>
Subject: [drivers/video/sis/init301.c] SiS_Pr->ChipType >= SIS_661 not evaluated
twice
Not sure whether this is important, but in drivers/video/sis/init301.c:1557:
if((SiS_Pr->ChipType >= SIS_661) || (SiS_Pr->SiS_ROMNew)) {
SiS_Pr->SiS_LCDTypeInfo = (SiS_GetReg(SiS_Pr->SiS_P3d4,0x39) & 0x7c) >> 2;
} else if((SiS_Pr->ChipType < SIS_315H) || (SiS_Pr->ChipType >= SIS_661)) {
SiS_Pr->SiS_LCDTypeInfo = temp >> 4;
note the duplicate test for 'SiS_Pr->ChipType >= SIS_661'
if it was true in the first test, the second test won't be evaluated.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists