linux-kernel - Re: [PATCH] fs/coda: remove static inline forward declarations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <84144f020802130654w51901fb1hf29d39ba86d87414@mail.gmail.com>
Date:	Wed, 13 Feb 2008 16:54:11 +0200
From:	"Pekka Enberg" <penberg@...helsinki.fi>
To:	"linux-os (Dick Johnson)" <linux-os@...logic.com>
Cc:	"Ilpo Järvinen" <ilpo.jarvinen@...sinki.fi>,
	jaharkes@...cmu.edu, "Andrew Morton" <akpm@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] fs/coda: remove static inline forward declarations

On Feb 13, 2008 3:43 PM, linux-os (Dick Johnson) <linux-os@...logic.com> wrote:
> You should not remove things just because you don't think they
> are necessary. They do no harm and removing them can cause
> code checking tools to issue diagnostic messages.

Err, no, Ilpo's patch looks good and the redundant declarations should
be removed. Andrew, please queue up this patch.

Reviewed-by: Pekka Enberg <penberg@...helsinki.fi>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/