linux-kernel - Re: [RFC v2 5/5] Atmel MCI: Driver for Atmel on-chip MMC controllers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e9c3a7c20802131111l86bf853y9173e23526aeb84c@mail.gmail.com>
Date:	Wed, 13 Feb 2008 12:11:58 -0700
From:	"Dan Williams" <dan.j.williams@...el.com>
To:	"Haavard Skinnemoen" <hskinnemoen@...el.com>
Cc:	linux-kernel@...r.kernel.org,
	"Shannon Nelson" <shannon.nelson@...el.com>,
	"David Brownell" <david-b@...bell.net>, kernel@...32linux.org,
	"Francis Moreau" <francis.moro@...il.com>,
	"Paul Mundt" <lethal@...ux-sh.org>,
	"Vladimir A. Barinov" <vbarinov@...mvista.com>,
	"Pierre Ossman" <drzeus-list@...eus.cx>
Subject: Re: [RFC v2 5/5] Atmel MCI: Driver for Atmel on-chip MMC controllers

On Jan 29, 2008 11:10 AM, Haavard Skinnemoen <hskinnemoen@...el.com> wrote:
[..]
> +/*
> + * Returns a mask of flags to be set in the command register when the
> + * command to start the transfer is to be sent.
> + */
> +static u32 atmci_prepare_data(struct mmc_host *mmc, struct mmc_data *data)
[..]
> +       for_each_sg(data->sg, sg, sg_len, i) {
> +               if (i == sg_len - 1)
> +                       dma_flags = DMA_PREP_INTERRUPT;
> +
> +               dev_vdbg(&mmc->class_dev, "  addr %08x len %u\n",
> +                               sg_dma_address(sg), sg_dma_len(sg));
> +
> +               desc = chan->device->device_prep_slave(chan,
> +                               sg_dma_address(sg), direction,
> +                               DMA_SLAVE_WIDTH_32BIT,
> +                               sg_dma_len(sg), dma_flags);
> +               desc->txd.callback = NULL;
> +               list_add_tail(&desc->client_node,
> +                               &host->dma.data_descs);
> +       }

Need to handle device_prep_slave returning NULL?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/