linux-kernel - Re: [PATCH] Adaptec AACRAID: convert fibctx->wait

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080213201533.GC27068@traven>
Date:	Wed, 13 Feb 2008 21:15:33 +0100
From:	Matthias Kaehlcke <matthias@...hlcke.net>
To:	James Bottomley <James.Bottomley@...senPartnership.com>
Cc:	aacraid@...ptec.com, linux-scsi@...r.kernel.org,
	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org
Subject: Re: [PATCH] Adaptec AACRAID: convert fibctx->wait_sem to completion

El Wed, Feb 13, 2008 at 01:09:00PM -0600 James Bottomley ha dit:

> On Wed, 2008-02-13 at 19:34 +0100, Matthias Kaehlcke wrote:
> > Adaptec AACRAID driver: The semaphore fibctx->wait_sem is used for
> > signalling an event. Convert it to a completion.
> 
> What's the purpose of doing this?  The aacraid implementation seems to
> be a classic PV semaphore, so why does it need to become a completion?

i had another look at the code and i agree with you. i didn't realize that
the semaphore is used as counting semaphore

please redirect the patch to /dev/null

thanks for reviewing the patch and pointing out my mistake

-- 
Matthias Kaehlcke
Linux System Developer
Barcelona

      In itself, homosexuality is as limiting as heterosexuality: the
     ideal should be to be capable of loving a woman or a man; either,
      a human being, without  feeling fear, restraint, or obligation
                          (Simone de Beauvoir)
                                                                 .''`.
    using free software / Debian GNU/Linux | http://debian.org  : :'  :
                                                                `. `'`
gpg --keyserver pgp.mit.edu --recv-keys 47D8E5D4                  `-
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/