linux-kernel - Re: [2.6 patch] thinkpad_acpi.c: make 2 functions static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080213230321.GC26196@khazad-dum.debian.net>
Date:	Wed, 13 Feb 2008 21:03:21 -0200
From:	Henrique de Moraes Holschuh <hmh@....eng.br>
To:	Adrian Bunk <bunk@...nel.org>
Cc:	Len Brown <len.brown@...el.com>, linux-kernel@...r.kernel.org
Subject: Re: [2.6 patch] thinkpad_acpi.c: make 2 functions static

On Wed, 13 Feb 2008, Adrian Bunk wrote:
> this_patch_makes_the_needlessly_global_hotkey_wakeup_reason_notify_change_and_hotkey_wakeup_hotunplug_complete_notify_change_static
> 
> Signed-off-by: Adrian Bunk <bunk@...nel.org>
> 
> ---
> 
> ;-)
> 
> da7d9b1a1d74ba5265d02e316a215540fe2daf19 diff --git a/drivers/misc/thinkpad_acpi.c b/drivers/misc/thinkpad_acpi.c
> index 7ba1aca..e2c7edd 100644
> --- a/drivers/misc/thinkpad_acpi.c
> +++ b/drivers/misc/thinkpad_acpi.c
> @@ -1689,7 +1689,7 @@ static ssize_t hotkey_wakeup_reason_show(struct device *dev,
>  static struct device_attribute dev_attr_hotkey_wakeup_reason =
>  	__ATTR(wakeup_reason, S_IRUGO, hotkey_wakeup_reason_show, NULL);
>  
> -void hotkey_wakeup_reason_notify_change(void)
> +static void hotkey_wakeup_reason_notify_change(void)
>  {
>  	if (tp_features.hotkey_mask)
>  		sysfs_notify(&tpacpi_pdev->dev.kobj, NULL,
> @@ -1708,7 +1708,7 @@ static struct device_attribute dev_attr_hotkey_wakeup_hotunplug_complete =
>  	__ATTR(wakeup_hotunplug_complete, S_IRUGO,
>  	       hotkey_wakeup_hotunplug_complete_show, NULL);
>  
> -void hotkey_wakeup_hotunplug_complete_notify_change(void)
> +static void hotkey_wakeup_hotunplug_complete_notify_change(void)
>  {
>  	if (tp_features.hotkey_mask)
>  		sysfs_notify(&tpacpi_pdev->dev.kobj, NULL,
> 

Acked-by: Henrique de Moraes Holschuh <hmh@....eng.br>

---

That said, I have no idea what toshiba-acpi has to do with the above patch
;-)

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/