linux-kernel - Re: [PATCH] adfs: trivial sparse fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20080213200439.1a501f83.akpm@linux-foundation.org>
Date:	Wed, 13 Feb 2008 20:04:39 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Harvey Harrison <harvey.harrison@...il.com>
Cc:	Russell King <rmk@....linux.org.uk>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] adfs: trivial sparse fix

On Wed, 13 Feb 2008 19:52:12 -0800 Harvey Harrison <harvey.harrison@...il.com> wrote:

> On Wed, 2008-02-13 at 19:39 -0800, Andrew Morton wrote:
> > On Wed, 13 Feb 2008 18:07:48 -0800 Harvey Harrison <harvey.harrison@...il.com> wrote:
> > 
> > > fs/adfs/dir_f.c:126:4: warning: do-while statement is not a compound statement
> > > 
> > > Signed-off-by: Harvey Harrison <harvey.harrison@...il.com>
> > > ---
> > >  fs/adfs/dir_f.c |    4 ++--
> > >  1 files changed, 2 insertions(+), 2 deletions(-)
> > > 
> > > diff --git a/fs/adfs/dir_f.c b/fs/adfs/dir_f.c
> > > index b9b2b27..ea7df21 100644
> > > --- a/fs/adfs/dir_f.c
> > > +++ b/fs/adfs/dir_f.c
> > > @@ -122,9 +122,9 @@ adfs_dir_checkbyte(const struct adfs_dir *dir)
> > >  		ptr.ptr8 = bufoff(bh, i);
> > >  		end.ptr8 = ptr.ptr8 + last - i;
> > >  
> > > -		do
> > > +		do {
> > >  			dircheck = *ptr.ptr8++ ^ ror13(dircheck);
> > > -		while (ptr.ptr8 < end.ptr8);
> > > +		} while (ptr.ptr8 < end.ptr8);
> > >  	}
> > >  
> > 
> > eh?  It's sparse which needs fixing here, surely?
> 
> Well, I only 'fixed' it this way to match the surrounding code.  The
> warning is a little odd.
> 

Yup, well, I changed the title to something sufficiently rude to get a
reaction from Linus when it crosses his desk.  We'll see ;)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/