lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 14 Feb 2008 06:50:52 +0100 From: Ingo Molnar <mingo@...e.hu> To: Adrian Bunk <bunk@...nel.org> Cc: Harvey Harrison <harvey.harrison@...il.com>, Andi Kleen <ak@...e.de>, Thomas Gleixner <tglx@...utronix.de>, hpa@...or.com, linux-kernel@...r.kernel.org Subject: Re: [2.6 patch] x86: make dump_pagetable() static * Adrian Bunk <bunk@...nel.org> wrote: > On Wed, Feb 13, 2008 at 02:27:47PM -0800, Harvey Harrison wrote: > > On Wed, 2008-02-13 at 23:31 +0200, Adrian Bunk wrote: > > > dump_pagetable() can now become static. > > > > > > Signed-off-by: Adrian Bunk <bunk@...nel.org> thanks, applied. > > I believe Andi Kleen wanted this kept global to make it easy to use > > when adding debugging code elsewhere. > > That's not a reason as long as his code isn't in the tree (and he > anyway has to patch the kernel for using it). correct. There's also a new CONFIG_X86_PTDUMP=y pagetable dumping debug feature now in x86.git#mm that produces much nicer output. Arjan: i it might be nice to make the new pagetable dumper triggerable from a SysRq - could you try the kernel/time/timer_list.c's SEQ_printf() trick to make the dumping dual-purpose? [so that it printk()'s if it should dump to the console and seq_printf()'s if it should dump via /proc] Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists