lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <200802140111.41883.lenb@kernel.org>
Date:	Thu, 14 Feb 2008 01:11:41 -0500
From:	Len Brown <lenb@...nel.org>
To:	Carlos Corbacho <carlos@...angeworlds.co.uk>
Cc:	Ingo Molnar <mingo@...e.hu>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-pm@...ts.linux-foundation.org
Subject: Re: [PATCH 2/2]  tc1100-wmi - Fail gracefully if ACPI is disabled

applied.

thanks,
-len

On Monday 11 February 2008 14:55, Carlos Corbacho wrote:
> tc1100-wmi - Fail gracefully if ACPI is disabled
> 
> From: Carlos Corbacho <carlos@...angeworlds.co.uk>
> 
> WMI drivers, like their ACPI counterparts, should also check if ACPI is
> disabled or not, and bail out if so, otherwise we cause a crash.
> 
> Spotted by Ingo Molnar.
> 
> Signed-off-by: Carlos Corbacho <carlos@...angeworlds.co.uk>
> CC: Ingo Molnar <mingo@...e.hu>
> CC: Linus Torvalds <torvalds@...ux-foundation.org>
> CC: Andrew Morton <akpm@...ux-foundation.org>
> CC: Len Brown <lenb@...nel.org>
> ---
> 
>  drivers/misc/tc1100-wmi.c |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> 
> diff --git a/drivers/misc/tc1100-wmi.c b/drivers/misc/tc1100-wmi.c
> index f25e4c9..cb8f79f 100644
> --- a/drivers/misc/tc1100-wmi.c
> +++ b/drivers/misc/tc1100-wmi.c
> @@ -263,6 +263,9 @@ static int __init tc1100_init(void)
>  {
>  	int result = 0;
>  
> +	if (acpi_disabled)
> +		return -ENODEV;
> +
>  	if (!wmi_has_guid(GUID))
>  		return -ENODEV;
>  
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ