| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <47B4098C.3060301@qumranet.com> Date: Thu, 14 Feb 2008 11:27:40 +0200 From: Avi Kivity <avi@...ranet.com> To: Sam Ravnborg <sam@...nborg.org> CC: Olaf Hering <olaf@...fle.de>, linux-kernel@...r.kernel.org Subject: Re: KVM: Export include/linux/kvm.h only if $ARCH actually supports KVM Sam Ravnborg wrote: > On Wed, Feb 13, 2008 at 09:43:49AM +0200, Avi Kivity wrote: > >> Olaf Hering wrote: >> >>>> Currently, make headers_check barfs due to <asm/kvm.h>, which >>>> <linux/kvm.h> >>>> includes, not existing. Rather than add a zillion <asm/kvm.h>s, export >>>> kvm.h >>>> only if the arch actually supports it. >>>> >>>> >>> This makes headers_install_all unreliable. >>> linux/kvm.h will not be exported, depending on what system the libc >>> headers will be generated. >>> >> I see. Any suggestions besides adding lots of asm-*/kvm.h? >> > > Do not include asm/kvm.h from linux/kvm.h. > And in the few places where it is needed explicit include asm/kvm.h before > linux/kvm.h. > > Alternatively inlcude asm/kvm.h inside #ifdef KERNEL" > so only userspace has to do explicit include of asm before linux variant. > That's not very nice for userspace, which needs asm/kvm.h for the arch specific parts of the interface. I'll add asm-*/kvm.h. -- Any sufficiently difficult bug is indistinguishable from a feature. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists