[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20080214120206.1a52f77d@core>
Date: Thu, 14 Feb 2008 12:02:06 +0000
From: Alan Cox <alan@...rguk.ukuu.org.uk>
To: Harvey Harrison <harvey.harrison@...il.com>
Cc: Jeff Garzik <jeff@...zik.org>, Tejun Heo <htejun@...il.com>,
LKML <linux-kernel@...r.kernel.org>,
linux-ide <linux-ide@...r.kernel.org>
Subject: Re: [PATCH 11/11] ata: fix sparse warnings in pata_legacy.c
On Wed, 13 Feb 2008 21:14:32 -0800
Harvey Harrison <harvey.harrison@...il.com> wrote:
> Let's use ld for legacy_data instead of shadowing these static
> int variables.
NAK - I purposefully used names that indicate what device the private
data is being used for in order to make it clear. Changing qdi and
winbond to ld_qdi and ld_winbond would avoid that and fix the shadowing
of the static value.
Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists