linux-kernel - Re: "gdth: update deprecated pci_find

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <47B45469.5070103@gmail.com>
Date:	Thu, 14 Feb 2008 15:47:05 +0100
From:	Jiri Slaby <jirislaby@...il.com>
To:	Sergio Luis <sergio@...ces.uece.br>
CC:	James Bottomley <James.Bottomley@...senPartnership.com>,
	SCSI Mailing List <linux-scsi@...r.kernel.org>,
	Jeff Garzik <jeff@...zik.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: "gdth: update deprecated pci_find_device" is incorrect

On 02/14/2008 03:44 PM, Jiri Slaby wrote:
> Hi,
> 
> commit
> 99109301d103fbf0de43fc5a580a406c12a501e0
> in jejb/scsi-rc-fixes-2.6.git is incorrect. You don't decrement pci 
> refcount on exit. Also you do not so on fail paths... I wonder why these 
> mistakes happen every second time somebody tries to do such change.
> 
> It leaked into mainline yet after "whole" two days, but what exactly 
> drives me crazy is, that Jeff commented it in similar way and nobody 
> reflected it!

BTW if you have more than one card, you protected the driver from no race, since 
you don't pci_dev_get of successfully grabbed cards.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/