| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Thu, 14 Feb 2008 10:08:13 -0500 From: Masami Hiramatsu <mhiramat@...hat.com> To: Harvey Harrison <harvey.harrison@...il.com> CC: Ingo Molnar <mingo@...e.hu>, Thomas Gleixner <tglx@...utronix.de>, "H. Peter Anvin" <hpa@...or.com>, LKML <linux-kernel@...r.kernel.org> Subject: Re: [PATCH] kprobes: remove sparse warnings from x86 Harvey Harrison : > arch/x86/kernel/kprobes.c:584:16: warning: symbol 'kretprobe_trampoline_holder' was not declared. Should it be static? > arch/x86/kernel/kprobes.c:676:6: warning: symbol 'trampoline_handler' was not declared. Should it be static? > > Make them static and add the __used attribute, approach taken from the > arm kprobes implementation. > > kretprobe_trampoline_holder uses inline assemly to define the global > symbol kretprobe_trampoline, but nothing ever calls the holder explicitly. > > trampoline handler is only called from inline assembly in the same file, > mark it used and static. > > Signed-off-by: Harvey Harrison <harvey.harrison@...il.com> It looks good to me. Acked-by: Masami Hiramatsu <mhiramat@...hat.com> Thank you, -- Masami Hiramatsu Software Engineer Hitachi Computer Products (America) Inc. Software Solutions Division e-mail: mhiramat@...hat.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists