[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <47B469E3.4080403@panasas.com>
Date: Thu, 14 Feb 2008 18:18:43 +0200
From: Boaz Harrosh <bharrosh@...asas.com>
To: James Bottomley <James.Bottomley@...senPartnership.com>
CC: Sven Köhler <skoehler@....de>,
Christoph Hellwig <hch@...radead.org>,
Jeff Garzik <jeff@...zik.org>,
linux-scsi <linux-scsi@...r.kernel.org>,
linux-kernel@...r.kernel.org, Joerg Dorchain <joerg@...chain.net>,
Jon Chelton <jchelton@...global.com>,
Stefan Priebe - allied internet ag
<s.priebe@...ied-internet.ag>
Subject: Re: [PATCH] gdth: bugfix for the at-exit problems
On Thu, Feb 14 2008 at 18:10 +0200, James Bottomley <James.Bottomley@...senPartnership.com> wrote:
> On Thu, 2008-02-14 at 13:58 +0200, Boaz Harrosh wrote:
>> This is a bugfix for the 2.6.24.x stable releases.
>>
>> gdth_exit would first remove all cards then stop the timer
>> and would not sync with the timer function. This caused a crash
>> in gdth_timer() when module was unloaded.
>> So del_timer_sync the timer before we delete the cards.
>>
>> also the reboot notifier function would crash. So unify
>> the exit and halt functions with a gdth_shutdown() that's
>> called by both.
>
> The patch looks fine now, thanks. Can we actually get a tester just to
> make sure there's nothing I missed.
>
> James
>
>
Yes, and the tester reported, a breakage. We are on it.
Apparently, you cannot do a full deallocation of resources
at reboot notifier, nor would you want to I guess.
But you can do the flush. The exit call is never called
on a reboot and the card access is valid to the end.
Please comment?
So I pretty much reverted that patch, but did leave some
cleanups.
Also we found the other problems reported with user-mode tools
and cat /proc/sys/gdth/0
so 2 patches on the way above reverted. Give us a few ours to test
every thing.
Thanks
Boaz
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists