[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <47B4A87F.8020800@cs.helsinki.fi>
Date: Thu, 14 Feb 2008 22:45:51 +0200
From: Pekka Enberg <penberg@...helsinki.fi>
To: Vegard Nossum <vegard.nossum@...il.com>
CC: Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
Daniel Walker <dwalker@...sta.com>,
Ingo Molnar <mingo@...e.hu>,
Richard Knutsson <ricknu-0@...dent.ltu.se>,
Andi Kleen <andi@...stfloor.org>,
Christoph Lameter <clameter@....com>
Subject: Re: [PATCH 1/4] kmemcheck v4
Vegard Nossum wrote:
> +DEFINE_PER_CPU(bool, kmemcheck_busy) = false;
> +DEFINE_PER_CPU(uint32_t, kmemcheck_addr1) = 0;
> +DEFINE_PER_CPU(uint32_t, kmemcheck_addr2) = 0;
> +DEFINE_PER_CPU(uint32_t, kmemcheck_reg_flags) = 0;
> +
> +DEFINE_PER_CPU(int, kmemcheck_num) = 0;
> +DEFINE_PER_CPU(int, kmemcheck_balance) = 0;
No need to explicitly initialize these, they're automatically zeroed.
> +
> +/*
> + * Called from the #PF handler.
> + */
> +void
> +kmemcheck_show(struct pt_regs *regs)
> +{
> + int n;
> +
> + BUG_ON(!irqs_disabled());
> +
> + if (__get_cpu_var(kmemcheck_balance) != 0) {
> + oops_in_progress = 1;
Why?
> + panic("kmemcheck: extra #PF");
> + }
> +
> +/*
> + * Called from the #DB handler.
> + */
> +void
> +kmemcheck_hide(struct pt_regs *regs)
> +{
> + BUG_ON(!irqs_disabled());
> +
> + --__get_cpu_var(kmemcheck_balance);
> + if (unlikely(__get_cpu_var(kmemcheck_balance) != 0)) {
> + oops_in_progress = 1;
ditto
> + panic("kmemcheck: extra #DB");
> + }
> +
> +static void
> +kmemcheck_read(struct pt_regs *regs, uint32_t address, unsigned int size)
> +{
> + void *shadow;
> + enum shadow status;
> +
> + shadow = address_get_shadow(address);
> + if (!shadow)
> + return;
> +
> + status = test(shadow, size);
> + if (status == SHADOW_INITIALIZED)
> + return;
> +
> + /* Don't warn about it again. */
> + set(shadow, size);
> +
> + oops_in_progress = 1;
I don't see you setting that to zero anywhere. What's this doing here
anyway?
> + error_save(status, address, size, regs);
> +}
> +
> +/*
> + * A faster implementation of memset() when tracking is enabled. We cannot
> + * assume that all pages within the range are tracked, so copying has
> to be
> + * split into page-sized (or smaller, for the ends) chunks.
> + */
> +void
> +kmemcheck_memset(unsigned long s, int c, size_t n)
> +{
> + unsigned long a_page, a_offset;
> + unsigned long b_page, b_offset;
Uhm, s/a_page/start_page/g, s/b_page/end_page/g and same for the offsets
too.
> diff --git a/include/linux/gfp.h b/include/linux/gfp.h
> index 0c6ce51..2138d64 100644
> --- a/include/linux/gfp.h
> +++ b/include/linux/gfp.h
> @@ -50,8 +50,9 @@ struct vm_area_struct;
> #define __GFP_THISNODE ((__force gfp_t)0x40000u)/* No fallback, no
> policies */
> #define __GFP_RECLAIMABLE ((__force gfp_t)0x80000u) /* Page is
> reclaimable */
> #define __GFP_MOVABLE ((__force gfp_t)0x100000u) /* Page is movable */
> +#define __GFP_NOTRACK ((__force gfp_t)0x200000u) /* Don't track
> with kmemcheck */
I think we can set __GFP_NOTRACK to zero to eliminate all dead code when
CONFIG_KMEMCHECK is disabled?
> diff --git a/include/linux/page-flags.h b/include/linux/page-flags.h
> index bbad43f..1593859 100644
> --- a/include/linux/page-flags.h
> +++ b/include/linux/page-flags.h
> @@ -90,6 +90,8 @@
> #define PG_reclaim 17 /* To be reclaimed asap */
> #define PG_buddy 19 /* Page is free, on buddy lists */
>
> +#define PG_tracked 20 /* Page is tracked by kmemcheck */
> +
I think we should re-use PG_owner_priv_1 for this (see PG_pinned, for
example).
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists