linux-kernel - Re: [RFC] bitmap relative operator for mempolicy extensions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 14 Feb 2008 12:55:49 -0800
From:	"Ray Lee" <ray-lk@...rabbit.org>
To:	"Paul Jackson" <pj@....com>
Cc:	"KOSAKI Motohiro" <kosaki.motohiro@...fujitsu.com>,
	rientjes@...gle.com, Lee.Schermerhorn@...com, mel@....ul.ie,
	ak@...e.de, linux-kernel@...r.kernel.org,
	akpm@...ux-foundation.org, clameter@....com
Subject: Re: [RFC] bitmap relative operator for mempolicy extensions

On Thu, Feb 14, 2008 at 8:35 AM, Paul Jackson <pj@....com> wrote:
> Kosaki-san wrote:
>  > i prefer another name [!relative].
>
>  Any suggestions?
>
>  I'll give the name some thought myself.
>  I like good names, and this is the right
>  time to get this one right.

'Relative map' implies a constant offset. What you have there is just
a map as relmap could be sparse (which, btw, would have been nice to
have in the example).

map_bitmap violates your naming convention, bitmap_map isn't all that
clear, bitmap_remap is taken, and while it is one-to-one and onto, I
think calling it bitmap_bijection would lose everyone except the
mathematicians. bitmap_onto? bitmap_map_onto? bitmap_map_bitmap_onto?

bitmap_read_my_kernel_doc?

Minor suggestion:
+ * and the n-th bit of @relmap is the m-th set bit of @relmap.

Perhaps s/is the/is also the/, so that the reader doesn't try to
second guess if you accidentally wrote @relmap twice instead of one of
them being @orig.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/