linux-kernel - Re: a7839e96 (PNP: increase max resources) breaks my ALSA intel8x0 sound card

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 14 Feb 2008 13:37:15 -0800 (PST)
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Bjorn Helgaas <bjorn.helgaas@...com>
cc:	Robert Hancock <hancockr@...w.ca>,
	Andrew Morton <akpm@...ux-foundation.org>, avuton@...il.com,
	yakui.zhao@...el.com, shaohua.li@...el.com, trenn@...e.de,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	alsa-devel@...a-project.org
Subject: Re: a7839e96 (PNP: increase max resources) breaks my ALSA intel8x0
 sound card

On Thu, 14 Feb 2008, Bjorn Helgaas wrote:
> 
> That means the PNP system driver has to be registered after the PCI
> driver.

After the PCI *subsystem*

Here's the actual problem:

[   31.133141] PCI: Unable to reserve mem region #1:4000@...f8000 for device 0000:00:1b.0

and here is what the resource tree *should* look like:

	febf8000-febfbfff : 0000:00:1b.0
	  febf8000-febfbfff : ICH HD audio

that's with a working sound driver.

Notice how there is *two* resources there: there's the PCI bus resource 
itself, the one called 0000:00:1b.0 (which was active at boot), and there 
is the "driver resource" that nests inside of it ("ICH HD audio").

The PCI bus resource is created and inserted into the resource when the 
PCI bus discovery happens - long before the driver comes along at all.

And the problem is this ABSOLUTE CRAP that happened much earlier:

[   22.906610] system 00:08: iomem range 0xfebfe000-0xfebfec00 has been reserved
[   22.906654] system 00:08: iomem range 0xfebfa000-0xfebfac00 has been reserved

which happens
 (a) before the PCI bus probing
 (b) despite the fact that the PCI bus probing already found something at 
     that address, and PnP shouldn't pollute the *correct* resources.

and the fix is to move that crap PnP to _after_ the PCI bus has been 
probed, and make sure that if the PnP resource clashes with the known good 
ones, then PnP gets the h*ll out and doesn't insert it at all.

See?

> We can't guarantee that, especially if the sound driver is
> a module.

This has *nothing* to do with the sound driver.

This has everything to do with the fact that the PnP layer is  a piece of 
crap and overrides/messes with the *correct* resources that we found 
during PCI bus probing.

Is that really so hard to understand?

So here is (for the *fifth* time) what PnP should do:

 - only try to insert its resources *after* the PCI bus probing has 
   happened
 - and if that fails, LET THE CRAP FAIL instead of making the *good* code 
   fail!

Ok?

			Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/