linux-kernel - Re: a7839e96 (PNP: increase max resources) breaks my ALSA intel8x0 sound card

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 14 Feb 2008 15:14:45 -0800 (PST)
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Bjorn Helgaas <bjorn.helgaas@...com>
cc:	Robert Hancock <hancockr@...w.ca>,
	Andrew Morton <akpm@...ux-foundation.org>, avuton@...il.com,
	yakui.zhao@...el.com, shaohua.li@...el.com, trenn@...e.de,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	alsa-devel@...a-project.org
Subject: Re: a7839e96 (PNP: increase max resources) breaks my ALSA intel8x0
 sound card



On Thu, 14 Feb 2008, Linus Torvalds wrote:
> 
> It should insert the resource to the root resource (or a bridge resource), 
> or not at all. If somebody else has already inserted a real device 
> resource, we already know about it, and the PnP information is going to be 
> just making things worse.

Hmm. The approach I'd take is to always insert the thing into the root 
resource. If we do want to let PnP insert it into some lower-level bus, 
we'd need to have some way to distinguish "bus" from "device", and we 
don't.

So right now, how about just making PnP/ACPI just use

	root = (flags & IORESOURCE_MEM) ? iomem_resource : ioport_resource;
	request_resource(root, newresource);

which is what we do for the e820 map and the other special resources we 
know about (ie the magic resources we make up ourselves like video ram and 
our standard PCI/ISA resource lists like the <0x100 DMA/PIC/FPU IO ports 
etc)

		Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/