[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <20080213193403.c0dde7f8.akpm@linux-foundation.org>
Date: Wed, 13 Feb 2008 19:34:03 -0800
From: Andrew Morton <akpm@...ux-foundation.org>
To: James Bottomley <James.Bottomley@...senPartnership.com>
Cc: torvalds@...ux-foundation.org, linux-scsi@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [GIT PATCH] SCSI bug fixes for 2.6.25-rc1
On Wed, 13 Feb 2008 19:11:53 -0600 James Bottomley <James.Bottomley@...senPartnership.com> wrote:
> > mptbase-reset-ioc-initiator-during-pci-resume.patch
> >
> > Fixes suspend/resume on all of Darrick's MPT cards. I first merged it
> > in September 2007.
>
> Patch presented by LSI but has gone back with comments
Five months is too long to fix a bug when someone has already sent us a
patch. If they insist on being this sluggish I'd suggest that you review
the patch yourself then just merge it. That will get their attention.
Maybe.
> > dell-cerc-support-for-megaraid_mbox.patch
>
> I need megaraid to sign off (and test) this one.
Two months, same story.
> > scsi-qlogicptic-section-fixes.patch
> >
> > Fixes a reference from .text into .init.text and hence might fix a
> > machine crash when this driver is build into vmlinux. Merged a week ago.
>
> This was the one we had the alternative fix for, wasn't it ... ?
In current mainline, __devinit qpti_sbus_probe() still is calling __init
qpti_chain_add() (for example). So in a CONFIG_HOTPLUG kernel, hotplugging
a new device (on sbus, ok, bad example ;)) will crash.
But Adrian has fixed six such bugs in there, maybe one of them can hit. I
don't think we've fixed these by alternative means, unless we've disabled
__devinit?
Still, we can discuss specific patches all day. I think there is a
_general_ problem getting bugfixes, warning fixes and cleanups into scsi
drivers within reasonable amounts of time?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists