linux-kernel - Re: [2.6.25-rc1] System no longer powers off after shutdown

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080215065746.GA8916@suse.de>
Date:	Thu, 14 Feb 2008 22:57:46 -0800
From:	Greg KH <gregkh@...e.de>
To:	Yinghai Lu <yhlu.kernel@...il.com>
Cc:	Ingo Molnar <mingo@...e.hu>, Frans Pop <elendil@...net.nl>,
	linux-kernel@...r.kernel.org, linux-acpi@...r.kernel.org
Subject: Re: [2.6.25-rc1] System no longer powers off after shutdown

On Thu, Feb 14, 2008 at 03:38:13PM -0800, Yinghai Lu wrote:
> On Wed, Feb 13, 2008 at 8:58 AM, Greg KH <gregkh@...e.de> wrote:
> >
> > On Wed, Feb 13, 2008 at 12:39:13PM +0100, Frans Pop wrote:
> >  > On Tuesday 12 February 2008, Greg KH wrote:
> >  > > On Tue, Feb 12, 2008 at 09:39:14PM +0100, Frans Pop wrote:
> >  > > > On Monday 11 February 2008, Frans Pop wrote:
> >  > > > > In general 2.6.25 if looking quite good on my desktop, but there's
> >  > > > > one important issue: the system no longer powers off after shutdown.
> >  > > > > This works fine with 2.6.24.
> >  > > >
> >  > > > Don't ask me why, but bisection shows this commit to be the cause of
> >  > > > the failure to power off:
> >  > > > commit c10997f6575f476ff38442fa18fd4a0d80345f9d
> >  > > > Author: Greg Kroah-Hartman <gregkh@...e.de>
> >  > > > Date:   Thu Dec 20 08:13:05 2007 -0800
> >  > > >
> >  > > >     Kobject: convert drivers/* from kobject_unregister() to
> >  > > > kobject_put()
> >  > > >
> >  > > > Because it seemed somewhat unlikely, I have double checked this by
> >  > > > doing an extra compilation for this commit and its predecessor.
> >  > >
> >  > > What is the symptom of not powering off?
> >  >
> >  > I already noticed yesterday that there's one hunk in that commit that's not
> >  > a straight replacement:
> >  > diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
> >  > index 9e102af..5efd555 100644
> >  > --- a/drivers/cpufreq/cpufreq.c
> >  > +++ b/drivers/cpufreq/cpufreq.c
> >  > @@ -1030,8 +1030,6 @@ static int __cpufreq_remove_dev (struct sys_device * sys_dev)
> >  >
> >  >         unlock_policy_rwsem_write(cpu);
> >  >
> >  > -       kobject_unregister(&data->kobj);
> >  > -
> >  >         kobject_put(&data->kobj);
> >  >
> >  >         /* we need to make sure that the underlying kobj is actually
> >  >
> >  >
> >  > So, just on the off chance, I applied the patch below and bingo, the system
> >  > powers off again. I doubt this will be the correct solution, but just in
> >  > case it is, here's my signed off. A comment why the double put is needed
> >  > would probably be good though.
> >
> >  There is a bug in the cpufreq kref logic that makes this "double put"
> >  necessary.  A real fix has already been posted to solve this issue, and
> >  I think it should be on it's way to Linus for -rc2 already.
> >
> >  Please let me know if -rc2 comes out without this needed fix.
> 
> after disable cpufreq, i got
> 
> ACPI: Preparing to enter system sleep state S5
> Disabling non-boot CPUs ...
> kvm: disabling virtualization on CPU1
> CPU 1 is now offline
> CPU1 is down
> kvm: disabling virtualization on CPU2
> CPU 2 is now offline
> ================> hang here.
> 
> but x86.git/mm could go through down all the cpus....
> 
> interesting...

I swear someone sent this patch in before.  Can you try this one below,
there seems to be an imbalance with kobject_get and _put.

thanks,

greg k-h

---
 drivers/cpufreq/cpufreq.c |    8 --------
 1 file changed, 8 deletions(-)

--- a/drivers/cpufreq/cpufreq.c
+++ b/drivers/cpufreq/cpufreq.c
@@ -1006,14 +1006,6 @@ static int __cpufreq_remove_dev (struct 
 	}
 #endif
 
-
-	if (!kobject_get(&data->kobj)) {
-		spin_unlock_irqrestore(&cpufreq_driver_lock, flags);
-		cpufreq_debug_enable_ratelimit();
-		unlock_policy_rwsem_write(cpu);
-		return -EFAULT;
-	}
-
 #ifdef CONFIG_SMP
 
 #ifdef CONFIG_HOTPLUG_CPU
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/