linux-kernel - Re: [PATCH] Fix left over EFI cache mapping problems

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <47B55EAC.10002@firstfloor.org>
Date:	Fri, 15 Feb 2008 10:43:08 +0100
From:	Andi Kleen <andi@...stfloor.org>
To:	"Huang, Ying" <ying.huang@...el.com>
CC:	Ingo Molnar <mingo@...e.hu>, torvalds@...l.org, tglx@...utronix.de,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Fix left over EFI cache mapping problems

Huang, Ying wrote:
> On Fri, 2008-02-15 at 09:48 +0100, Andi Kleen wrote:
>> On Fri, Feb 15, 2008 at 12:48:06PM +0800, Huang, Ying wrote:
>>> This patch has been tested on Intel x86 platform with EFI 32/64.
>> Can EFI_PAGE_SIZE ever be < 4k? If yes you would need to round up
>> first to linux page size before shifting.
> 
> Yes. It is needed. And md->virt_addr should be processed as follow:
> 
> md->virt_addr & PAGE_MASK
> 
> before fed into set_memory_*.

If you do that you also need to add the old offset into the page
to the size.

I just mention it because ioremap_change_attr() did that wrong
before my patch yesterday :)

-Andi

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/