linux-kernel - Re: [RFC][PATCH] modular kgdb-light (was: Re: [git pull] kgdb-light -v10)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 15 Feb 2008 14:32:38 +0100
From:	Andi Kleen <andi@...stfloor.org>
To:	Jan Kiszka <jan.kiszka@...mens.com>
Cc:	Andi Kleen <andi@...stfloor.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Ingo Molnar <mingo@...e.hu>, linux-kernel@...r.kernel.org,
	"Frank Ch. Eigler" <fche@...hat.com>,
	Roland McGrath <roland@...hat.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Jason Wessel <jason.wessel@...driver.com>,
	Jan Kiszka <jan.kiszka@....de>
Subject: Re: [RFC][PATCH] modular kgdb-light (was: Re: [git pull] kgdb-light -v10)

On Fri, Feb 15, 2008 at 01:35:36PM +0100, Jan Kiszka wrote:
> Andi Kleen wrote:
> >> This includes things like having "breakpoint reservations" (discussed 
> >> earlier) and just generally trying to add lots of infrastructure to make 
> >> kgdb "fit in" to the kernel.
> > 
> > I think that part is actually mostly ok now (old kgdb stubs were
> > much worse in this regard) 
> > 
> > I still think the ultimative proof for this would be working
> > "modprobe kgdb" though.
> 
> To pick up this idea again I did the experimental patch below. It
> applies against Jason's latest kgdb-light patch queue:

Very nice! If it's that simple then the kgdb integration is really
clean.

> 
> http://git.kernel.org/?p=linux/kernel/git/jwessel/linux-2.6-kgdb.git;a=shortlog;h=for_ingo
> 
> The patch nicely demonstrates what deeper dependencies on kernel
> services currently exist in kgdb-light. The following symbols were
> unresolvable:
> 

Some comments on the specific patch:

>  o genapic - for send_IPI_allbutself, ie. CPU roundup

I would rather export some generic wrapper for that than the full genapic
structure.

>  o machine_emergency_restart - for implementing "R0" gdb packet

Hmm, might be a bit dangerous to call this directly -- there are various
quirks with e.g. not rebooting on CPU #0 and not resetting APIC 
state. But ok [this is not directly related to the fact that it's
exported now, just mentioning this in general]

-Andi

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/