| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-id: <47B59CC2.20404@acm.org> Date: Fri, 15 Feb 2008 08:08:02 -0600 From: Corey Minyard <minyard@....org> To: Peter Zijlstra <peterz@...radead.org> Cc: Andrew Morton <akpm@...l.org>, Konstantin Baydarov <kbaidarov@...mvista.com>, OpenIPMI Developers <openipmi-developer@...ts.sourceforge.net>, Linux Kernel <linux-kernel@...r.kernel.org> Subject: Re: [Openipmi-developer] [PATCH 3/4] IPMI: convert locked counters to atomics Peter Zijlstra wrote: > On Thu, 2008-02-14 at 12:30 -0600, Corey Minyard wrote: > > >> +/* The command didn't have anyone waiting for it. */ >> +#define IPMI_STAT_unhandled_commands 23 >> + >> +/* Invalid data in an event. */ >> +#define IPMI_STAT_invalid_events 24 >> + >> +/* Events that were received with the proper format. */ >> +#define IPMI_STAT_events 25 >> + >> +/* When you add a statistic, you must update this value. */ >> +#define IPMI_NUM_STATS 26 >> > > This shouts enum to me.. > Someone else asked about this, and I wasn't too sure. It seems from the CodingStyle document that enums are preferred for things like this, but I current kernel code seems a mixed bag. An enum is cleaner and more reliable, IMHO. I'll convert it, I think. Thanks, -corey -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists