linux-kernel - Re: [PATCH] libata: Add MMIO support to pata

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080215155332.2b89c429@core>
Date:	Fri, 15 Feb 2008 15:53:32 +0000
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Guennadi Liakhovetski <g.liakhovetski@....de>
Cc:	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	Tim Ellis <tim@...dg.com>, linux-kernel@...r.kernel.org,
	jeff@...zik.org
Subject: Re: [PATCH] libata: Add MMIO support to pata_sil680

> > That's strange though. Somebody with knowledge of that HW (or specs) who
> > can spot something ? Could it be an issue with timing ?
> > 
> > I don't have HW access to this machine. If somebody could send one to me
> > I could do more investigation.
> 
> Ben, would an ssh access to such a machine and to a terminal server 
> suffice?

It says clearly in the code where to start. See the FIXME notes in both
libata-sff and libata-core about MMIO. Neither the DMA transfer start or
the probe SRST sequence are correct with MMIO posting and this hasn't
been fixed as I pointed out was needed when I originally NAKked the
change.

Without those being fixed (especially SRST) on any device with heavy PCI
posting of mmio your controller *wont work*.

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/