linux-kernel - Re: [patch] fuse: fix permission checking

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1203107738.15275.39.camel@brick>
Date:	Fri, 15 Feb 2008 12:35:38 -0800
From:	Harvey Harrison <harvey.harrison@...il.com>
To:	Miklos Szeredi <miklos@...redi.hu>
Cc:	akpm@...ux-foundation.org, linux-kernel@...r.kernel.org,
	stable@...nel.org
Subject: Re: [patch] fuse: fix permission checking

On Fri, 2008-02-15 at 11:23 +0100, Miklos Szeredi wrote:
> This is for 2.6.25 and 2.6.24.y, but NOT for 2.6.23.y.
> 
> Thanks,
> Miklos
> ----
> 
> From: Miklos Szeredi <mszeredi@...e.cz>
> 
> I added a nasty local variable shadowing bug to fuse in 2.6.24, with
> the result, that the 'default_permissions' mount option is basically
> ignored.
> 
> How did this happen?
> 
>  - old err declaration in inner scope
>  - new err getting declared in outer scope
>  - 'return err' from inner scope getting removed
>  - old declaration not being noticed
> 
> -Wshadow would have saved us, but it doesn't seem practical for
> the kernel :(
> 
> More testing would have also saved us :((

sparse would have saved you too.

Harvey

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/