[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <40f31dec0802151400r7423c8e9w2524cba76618e07e@mail.gmail.com>
Date: Sat, 16 Feb 2008 00:00:34 +0200
From: "Nick Kossifidis" <mickflemm@...il.com>
To: "Jiri Slaby" <jirislaby@...il.com>
Cc: linville@...driver.com, linux-kernel@...r.kernel.org,
linux-wireless@...r.kernel.org, ath5k-devel@...ts.ath5k.org,
"Luis R. Rodriguez" <mcgrof@...il.com>
Subject: Re: [PATCH 1/3] WDEV: ath5k, fix lock imbalance
2008/2/15, Jiri Slaby <jirislaby@...il.com>:
> Omitted lock causes sparse warning
> drivers/net/wireless/ath5k/base.c:1682:1: warning: context imbalance in 'ath5k_tasklet_rx' - different lock contexts for basic block
>
> Add the lock to the guilty fail path.
>
> Signed-off-by: Jiri Slaby <jirislaby@...il.com>
> Cc: Nick Kossifidis <mickflemm@...il.com>
> Cc: Luis R. Rodriguez <mcgrof@...il.com>
> ---
> drivers/net/wireless/ath5k/base.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/net/wireless/ath5k/base.c b/drivers/net/wireless/ath5k/base.c
> index ddc8714..49d38e8 100644
> --- a/drivers/net/wireless/ath5k/base.c
> +++ b/drivers/net/wireless/ath5k/base.c
> @@ -1715,6 +1715,7 @@ ath5k_tasklet_rx(unsigned long data)
> break;
> else if (unlikely(ret)) {
> ATH5K_ERR(sc, "error in processing rx descriptor\n");
> + spin_unlock(&sc->rxbuflock);
> return;
> }
>
>
Acked-by: Nick Kossifidis <mickflemm@...il.com>
--
GPG ID: 0xD21DB2DB
As you read this post global entropy rises. Have Fun ;-)
Nick
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists