linux-kernel - Re: [PATCH] Add list_for_each

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080216084723.GD9962@cs181133002.pp.htv.fi>
Date:	Sat, 16 Feb 2008 10:47:23 +0200
From:	Adrian Bunk <bunk@...nel.org>
To:	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
Cc:	linux-kernel@...r.kernel.org, davem@...emloft.net,
	dipankar@...ibm.com
Subject: Re: [PATCH] Add list_for_each_rcu to features-removal list

On Mon, Jan 28, 2008 at 04:25:00AM -0800, Paul E. McKenney wrote:
> Hello!
> 
> The list_for_each_entry_rcu() primitive should be used instead of
> list_for_each_rcu(), as the former is easier to use and provides
> better type safety.  This patch therefore adds list_for_each_rcu()
> to the Documentation/feature-removal-schedule.txt file (for mid-2008)
> and marks its comment header deprecated.
> 
> Signed-off-by: Paul E. McKenney <paulmck@...ux.vnet.ibm.com>
> ---
> 
>  Documentation/feature-removal-schedule.txt |   10 ++++++++++
>  include/linux/list.h                       |    5 ++++-
>  2 files changed, 14 insertions(+), 1 deletion(-)
> 
> diff -urpNa -X dontdiff linux-2.6.24/Documentation/feature-removal-schedule.txt linux-2.6.24-dep-lfeRCU/Documentation/feature-removal-schedule.txt
> --- linux-2.6.24/Documentation/feature-removal-schedule.txt	2008-01-24 14:58:37.000000000 -0800
> +++ linux-2.6.24-dep-lfeRCU/Documentation/feature-removal-schedule.txt	2008-01-28 04:00:49.000000000 -0800
> @@ -333,3 +333,13 @@ Why:	This driver has been marked obsolet
>  Who:	Stephen Hemminger <shemminger@...ux-foundation.org>
>  
>  ---------------------------
> +
> +What:	list_for_each_rcu() primitive
> +When:	July 2008
> +Files:	include/linux/list.h
> +Why:	The list_for_each_entry_rcu() primitive should be used instead,
> +	as it is less error-prone and provides better type safety.
> +Who:	Paul E. McKenney <paulmck@...ux.vnet.ibm.com>
>...

Declaring something as deprecated doesn't automatically convert the 
in-kernel users.

And once there are no in-kernel users left you can kill it immediately.

The only working way for getting rid of list_for_each_rcu() is:
- send patches for all in-kernel usages to the maintainers of the code
  in question now
- once all of these patches have entered Linus' tree (which might not
  be before the 2.6.26 merge window) you can remove list_for_each_rcu()

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/