linux-kernel - Re: [patch] checkpatch.pl: revert wrong --file message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.1.00.0802161026550.7583@apollo.tec.linutronix.de>
Date:	Sat, 16 Feb 2008 11:18:52 +0100 (CET)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Andi Kleen <ak@...e.de>
cc:	Ingo Molnar <mingo@...e.hu>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, Andy Whitcroft <andyw@...ibm.com>
Subject: Re: [patch] checkpatch.pl: revert wrong --file message

On Fri, 15 Feb 2008, Andi Kleen wrote:
> > In the past few months we frequently mentioned checkpatch.pl --file to 
> > arch/x86 newbies and it's been a great source of cleanup patches and it 
> > has become an integral part of our workflow. Newbies should start with 
> > small baby steps, with trivial patches, they should learn to write clean 
> > code, they should learn how to interact with other Linux developers and 
> > then they'll evolve over time towards larger changes.
>
> On the other hand I found that people who already know enough C and start 
> hacking code directly do not really need the "white space only" stage.
> They just start hacking code directly. They usually need some education
> on how to properly send patches, but that can be always done with
> real bug fixes or changes they did.

People, who do cleanups - I'm not talking about running lindent here -
read through the code while they fix it up.

Actually they find bugs that way or at least come up with useful
questions about code which is not obvious in the first place.

Discouraging such cleanups with a pretty offensive warning is
counterproductive.

Thanks,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/