linux-kernel - Re: [PATCHSET] printk: implement printk_header() and merging printk, take #3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <47B6EF9D.5090804@rtr.ca>
Date:	Sat, 16 Feb 2008 09:13:49 -0500
From:	Mark Lord <liml@....ca>
To:	Tejun Heo <htejun@...il.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>, jeff@...zik.org,
	linux-ide@...r.kernel.org, jengelh@...putergmbh.de, matthew@....cx,
	randy.dunlap@...cle.com, daniel.ritz-ml@...ssonline.ch,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCHSET] printk: implement printk_header() and merging printk,
 take #3

Tejun Heo wrote:
> Andrew Morton wrote:
>>> So, I guess it's NACK w/o suggested alternatives, right?
>> I wouldn't nack without good reasons, and I have none here.  I don't have
>> very strong opinions either way.
> 
> I was just wondering whether I should just go with snprintf dancing in
> eh_link_report, which does make sense if not many need merging printk.
..

Any chance you could poke through snprintf() and look for the off-by-one bug
on the return result?  (I think it happens when "n" is exceeded).

:)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/