linux-kernel - Re: [PATCH] fs/ufs/util.h 2nd parameter of fs32_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080216201650.GA18444@rain>
Date:	Sat, 16 Feb 2008 23:16:53 +0300
From:	Evgeniy Dushistov <dushistov@...l.ru>
To:	Roel Kluin <12o3l@...cali.nl>
Cc:	lkml <linux-kernel@...r.kernel.org>,
	Mark Fortescue <mark@...hpc.demon.co.uk>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] fs/ufs/util.h 2nd parameter of fs32_to_cpu is not
	boolean

On Sat, Feb 16, 2008 at 08:38:15PM +0100, Roel Kluin wrote:
> from: fs/befs/endian.h +33
> static inline u32
> fs32_to_cpu(const struct super_block *sb, fs32 n)
> {
>         if (BEFS_SB(sb)->byte_order == BEFS_BYTESEX_LE)
>                 return le32_to_cpu((__force __le32)n);
>         else
>                 return be32_to_cpu((__force __be32)n);
> }
> 
> The 2nd parameter is not boolean
> ---
> Test the return value, rather than passing a boolean
> 
> Signed-off-by: Roel Kluin <12o3l@...cali.nl>
> ---
> diff --git a/fs/ufs/util.h b/fs/ufs/util.h
> index b26fc4d..23ceed8 100644
> --- a/fs/ufs/util.h
> +++ b/fs/ufs/util.h
> @@ -58,7 +58,7 @@ ufs_set_fs_state(struct super_block *sb, struct ufs_super_block_first *usb1,
>  {
>  	switch (UFS_SB(sb)->s_flags & UFS_ST_MASK) {
>  	case UFS_ST_SUNOS:
> -		if (fs32_to_cpu(sb, usb3->fs_postblformat == UFS_42POSTBLFMT)) {
> +		if (fs32_to_cpu(sb, usb3->fs_postblformat) == UFS_42POSTBLFMT) {
>  			usb1->fs_u0.fs_sun.fs_state = cpu_to_fs32(sb, value);
>  			break;
>  		}

Yeah, in origin patch, which introduced this code was the similar
misprint. It is sad that after review only one was fixed,
and the second go to mainline.

Acked-by: Evgeniy Dushistov <dushistov@...l.ru>

-- 
/Evgeniy

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/