| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20080216225637.GE24479@shadowen.org> Date: Sat, 16 Feb 2008 22:56:37 +0000 From: Andy Whitcroft <andyw@...ibm.com> To: Pekka Enberg <penberg@...helsinki.fi> Cc: Thomas Gleixner <tglx@...utronix.de>, Andi Kleen <ak@...e.de>, Ingo Molnar <mingo@...e.hu>, Linus Torvalds <torvalds@...ux-foundation.org>, linux-kernel@...r.kernel.org Subject: Re: [patch] checkpatch.pl: revert wrong --file message On Sat, Feb 16, 2008 at 12:27:33PM +0200, Pekka Enberg wrote: > Hi, > > On Feb 16, 2008 12:18 PM, Thomas Gleixner <tglx@...utronix.de> wrote: > > People, who do cleanups - I'm not talking about running lindent here - > > read through the code while they fix it up. > > > > Actually they find bugs that way or at least come up with useful > > questions about code which is not obvious in the first place. > > > > Discouraging such cleanups with a pretty offensive warning is > > counterproductive. > > Well, it's not just about cleanup patches submitted by "newbies". I > use checkpatch for development too and the warning is real PITA for > that. The warning is suppressed on -q as its a pain indeed if one is using it to check files and you are not intending a single file cleanup. Is the concensus the warning is useful, or unhelpful. -apw -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists