linux-kernel - [PATCH] snd-hda-intel: don't print using snd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <47B80CED.3060903@gmail.com>
Date:	Sun, 17 Feb 2008 11:31:09 +0100
From:	Adel Gadllah <adel.gadllah@...il.com>
To:	kernel list <linux-kernel@...r.kernel.org>
CC:	tiwai@...e.de, Chuck Ebbert <cebbert@...hat.com>
Subject: [PATCH] snd-hda-intel: don't print using snd_printdd on device open

Hi,

When CONFIG_SND_DEBUG_DETECT is set the hda-intel driver prints verbose 
info like this:

ALSA sound/pci/hda/hda_intel.c:1259: azx_pcm_prepare: bufsize=0x4400,
fragsize=0x1100, format=0x11
ALSA sound/pci/hda/hda_codec.c:682: hda_codec_setup_stream: NID=0x7,
stream=0x5, channel=0, format=0x11
ALSA sound/pci/hda/hda_codec.c:682: hda_codec_setup_stream: NID=0x3,
stream=0x5, channel=0, format=0x11
ALSA sound/pci/hda/hda_codec.c:682: hda_codec_setup_stream: NID=0x3,
stream=0x0, channel=0, format=0x0
ALSA sound/pci/hda/hda_codec.c:682: hda_codec_setup_stream: NID=0x7,
stream=0x0, channel=0, format=0x0
ALSA sound/pci/hda/hda_codec.c:682: hda_codec_setup_stream: NID=0x3,
stream=0x0, channel=0, format=0x0

Every time when an app opens the sound device.
This makes it impossible for distribution to enable this config option 
(to get more debug information for bug reports),
because its way too noisy.
SND_DEBUG_DETECT should only print stuff once when loading the driver.
 
There are some options to fix this:

1) don't print anything in functions that gets called when the device gets
opened/prepared for output.

2) use snd_printd instead of snd_printdd and make 
CONFIG_SND_DEBUG_DETECT not depend on CONFIG_SND_DEBUG (this should be 
done anyway)

3) introduce a CONFIG_SND_DEBUG_DETECT_VERBOSE and snd_printddv and use 
it in this places (this one should be disabled by distributions then)

The attached patch implements 1) if 2) or 3) is preferred I can send a 
patch to do this.

Please CC me when replying


----------

snd-hda-intel: don't print using snd_printdd on device open

Signed-off-by: Adel Gadllah <adel.gadllah@...il.com>
CC: Takashi Iwai <tiwai@...e.de>
CC: Chuck Ebbert <cebbert@...hat.com>

diff -upNr linux-2.6.24.2.orign/sound/pci/hda/hda_codec.c 
linux-2.6.24.2/sound/pci/hda/hda_codec.c
--- linux-2.6.24.2.orign/sound/pci/hda/hda_codec.c    2008-02-11 
06:51:11.000000000 +0100
+++ linux-2.6.24.2/sound/pci/hda/hda_codec.c    2008-02-17 
11:08:58.000000000 +0100
@@ -677,9 +677,6 @@ void snd_hda_codec_setup_stream(struct h
     if (!nid)
         return;
 
-    snd_printdd("hda_codec_setup_stream: "
-            "NID=0x%x, stream=0x%x, channel=%d, format=0x%x\n",
-            nid, stream_tag, channel_id, format);
     snd_hda_codec_write(codec, nid, 0, AC_VERB_SET_CHANNEL_STREAMID,
                 (stream_tag << 4) | channel_id);
     msleep(1);
diff -upNr linux-2.6.24.2.orign/sound/pci/hda/hda_intel.c 
linux-2.6.24.2/sound/pci/hda/hda_intel.c
--- linux-2.6.24.2.orign/sound/pci/hda/hda_intel.c    2008-02-11 
06:51:11.000000000 +0100
+++ linux-2.6.24.2/sound/pci/hda/hda_intel.c    2008-02-17 
11:10:16.000000000 +0100
@@ -1249,9 +1249,6 @@ static int azx_pcm_prepare(struct snd_pc
         return -EINVAL;
     }
 
-    snd_printdd("azx_pcm_prepare: bufsize=0x%x, fragsize=0x%x, "
-            "format=0x%x\n",
-            azx_dev->bufsize, azx_dev->fragsize, azx_dev->format_val);
     azx_setup_periods(azx_dev);
     azx_setup_controller(chip, azx_dev);
     if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK)





--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/