linux-kernel - Re: Geode GX/LX watchdog timer (RESEND)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <47B88F2F.1030200@i4.informatik.rwth-aachen.de>
Date:	Sun, 17 Feb 2008 20:46:55 +0100
From:	Arnd Hannemann <hannemann@...informatik.rwth-aachen.de>
To:	Iain Paton <ilp@...l.darkvoyage.org.uk>
CC:	Adrian Bunk <bunk@...nel.org>,
	Jordan Crouse <jordan.crouse@....com>,
	Andres Salomon <dilinger@...ued.net>, marc.jones@....com,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	wim@...ana.be
Subject: Re: Geode GX/LX watchdog timer (RESEND)

Iain Paton schrieb:
> Adrian Bunk wrote:
>> On Sun, Feb 17, 2008 at 03:46:01PM +0100, Arnd Hannemann wrote:
>>> Never tried to built it as a module.
>>> Probably there are issues with that. If I remember correctly I saw a
>>> patch in 2.6.25-rc which
>>> mentioned that using mfgpt in modules won't work. Does this apply to
>>> 2.6.24 as well?
>>
>> For using code from modules it must be explicitely
>> EXPORT_SYMBOL{,GPL}'ed.
>>
>> Adding
>>   EXPORT_SYMBOL_GPL(geode_mfgpt_toggle_event);
>> and
>>   EXPORT_SYMBOL_GPL(geode_mfgpt_alloc_timer);
>> below the respective functions in mfgpt_32.c should fix this issue.
> 
> I couldn't find the patch Arnd mentioned on lkml or in Linus git tree,
> but adding the lines suggested by Adrian gets me a working module.


I meant commit fa28e067c3b8af96c79c060e163b1387c172ae75 in linus git, but seems
I misinterpreted it.

>     x86: GEODE: MFGPT: drop module owner usage from MFGPT API
>     
>     We had planned to use the 'owner' field for allowing re-allocation of
>     MFGPTs; however, doing it by module owner name isn't flexible enough.  So,
>     drop this for now.  If it turns out that we need timers in modules, we'll
>     need to come up with a scheme that matches the write-once fields of the
>     MFGPTx_SETUP register, and drops ponies from the sky.
>     
>     Signed-off-by: Andres Salomon <dilinger@...ian.org>
>     Signed-off-by: Jordan Crouse <jordan.crouse@....com>
>     Signed-off-by: Ingo Molnar <mingo@...e.hu>
>     Signed-off-by: Thomas Gleixner <tglx@...utronix.de>

Best regards,
Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/