linux-kernel - Re: [patch 2/2] x86: lds - Use THREAD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <47B89501.5090108@zytor.com>
Date:	Sun, 17 Feb 2008 12:11:45 -0800
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Cyrill Gorcunov <gorcunov@...il.com>
CC:	Sam Ravnborg <sam@...nborg.org>, ak@...e.de, mingo@...e.hu,
	tglx@...utronix.de, linux-kernel@...r.kernel.org
Subject: Re: [patch 2/2] x86: lds - Use THREAD_SIZE instead of numeric	constant

Cyrill Gorcunov wrote:
> 
> Thanks Peter for comments. Peter could you clarify for me a bit
> more on the string:
> 
> x86/kernel/head_32.S:339
> 
> 	/* Set up the stack pointer */
> 	lss stack_start,%esp
> 
> but stack_start is defined as head_32.S:647
> 
> .data
> ENTRY(stack_start)
> 	.long init_thread_union+THREAD_SIZE
> 
> so stack_start *must* be aligned with THREAD_SIZE in vmlinux.lds
> at compiling time. There is no PDA at this booting time. Am I wrong?
> If you're too busy - just reply me like "Read the code" ;)
> 

That doesn't follow.

You're saying that it *must* be aligned, I don't think that's true 
anymore; I think nowadays it's more accurate to say that it *is* 
aligned, but I don't think that's fundamental.

	-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/