linux-kernel - Re: [PATCH v2] Re: 2.6.25-rc2-mm1 (wakeup)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <47B7BC4C.8070502@oracle.com>
Date:	Sat, 16 Feb 2008 20:47:08 -0800
From:	Randy Dunlap <randy.dunlap@...cle.com>
To:	"H. Peter Anvin" <hpa@...or.com>
CC:	"Rafael J. Wysocki" <rjw@...k.pl>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, pavel@...e.cz,
	Len Brown <lenb@...nel.org>, sam@...nborg.org
Subject: Re: [PATCH v2] Re: 2.6.25-rc2-mm1 (wakeup)

H. Peter Anvin wrote:
> Randy Dunlap wrote:
>> On Sat, 16 Feb 2008 19:58:06 -0800 H. Peter Anvin wrote:
>>
>>> Randy Dunlap wrote:
>>>> Yes, adding -m32 to the X86_32 config ccflags (as is done for the
>>>> X86_64 case) makes it build for me.  (like patch below)
>>>>
>>> It's wrong, though, because you can't assume a 32-bit compiler knows 
>>> about -m32.
>>>
>>> You need $(call cc-option,-m32).
>>
>> -cflags-$(CONFIG_X86_32) :=
>> +cflags-$(CONFIG_X86_32) := $(call cc-option, -m32)
>>  cflags-$(CONFIG_X86_64) := -m32
> 
> I think this works for both; that's what we do for arch/x86/boot.

OK, that makes sense.  I think I'll let Rafael complete it.

-- 
~Randy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/