linux-kernel - Re: [PATCH 4/5] signal(ia64): add a signal stack overflow check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080218123052.GG21012@parisc-linux.org>
Date:	Mon, 18 Feb 2008 05:30:52 -0700
From:	Matthew Wilcox <matthew@....cx>
To:	Shi Weihua <shiwh@...fujitsu.com>
Cc:	tony.luck@...el.com, linux-kernel@...r.kernel.org,
	linux-ia64@...r.kernel.org
Subject: Re: [PATCH 4/5] signal(ia64): add a signal stack overflow check

On Mon, Feb 18, 2008 at 06:26:23PM +0800, Shi Weihua wrote:
> +			if (!rbs_on_sig_stack(scr->pt.ar_bspstore))
> +				new_rbs = (current->sas_ss_sp +
> +					  sizeof(long) - 1) & ~(sizeof(long) - 1);

I know you're only moving this code, but how about fixing it to use
ALIGN at the same time?

+			if (!rbs_on_sig_stack(scr->pt.ar_bspstore))
+				new_rbs = ALIGN(current->sas_ss_sp,
+						sizeof(long));

-- 
Intel are signing my paycheques ... these opinions are still mine
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours.  We can't possibly take such
a retrograde step."
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/