linux-kernel - Re: [2.6 patch] fs/drop_caches.c: make 2 functions static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080218050147.17f5ee0b.akpm@linux-foundation.org>
Date:	Mon, 18 Feb 2008 05:01:47 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Adrian Bunk <bunk@...nel.org>
Cc:	linux-kernel@...r.kernel.org, Neil Brown <neilb@...e.de>
Subject: Re: [2.6 patch] fs/drop_caches.c: make 2 functions static

On Sun, 17 Feb 2008 10:17:46 +0200 Adrian Bunk <bunk@...nel.org> wrote:

> This patch makes the following needlessly global functions static:
> - drop_pagecache()
> - drop_slab()
> 
> Signed-off-by: Adrian Bunk <bunk@...nel.org>
> 
> ---
> 
>  fs/drop_caches.c   |    4 ++--
>  include/linux/mm.h |    2 --
>  2 files changed, 2 insertions(+), 4 deletions(-)
> 
> 32191754eb7aed31406850a082565bc428268a08 diff --git a/fs/drop_caches.c b/fs/drop_caches.c
> index 59375ef..e2c6b65 100644
> --- a/fs/drop_caches.c
> +++ b/fs/drop_caches.c
> @@ -25,7 +25,7 @@ static void drop_pagecache_sb(struct super_block *sb)
>  	spin_unlock(&inode_lock);
>  }
>  
> -void drop_pagecache(void)
> +static void drop_pagecache(void)
>  {
>  	struct super_block *sb;
>  
> @@ -45,7 +45,7 @@ restart:
>  	spin_unlock(&sb_lock);
>  }
>  
> -void drop_slab(void)
> +static void drop_slab(void)
>  {
>  	int nr_objects;
>  

This was originally done because Neil said that he planned to use these in
nfsd.  I guess that didn't happen, and an additional patch would be needed
here anyway to do the module exports.  So....  zap.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/