linux-kernel - Re: Re: [patch 1/2] x86: define outb_pic and inb_pic to stop using outb_p and inb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 18 Feb 2008 12:30:10 -0500
From:	"David P. Reed" <dpreed@...d.com>
To:	Alan Cox <alan@...rguk.ukuu.org.uk>
CC:	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>, linux-kernel@...r.kernel.org
Subject: Re: Re: [patch 1/2] x86: define outb_pic and inb_pic
 to stop using outb_p and inb_p

Alan Cox wrote:
>> +unsigned char inb_pic(unsigned int port)
>> +{
>> +	/* delay for some accesses to PIC on motherboard or in chipset must be
>> +	   at least one microsecond, but be safe here. */
>> +	unsigned char value = inb(port);
>> +	udelay(2);
>> +	return value;
>> +}
>>     
>
> inline it. Its almost no instructions
>
>   
Will do. Assume you desire inlining of the outb_pic, and also the 
inb_pit and outb_pit routines.  Didn't do it because the code is 
slightly bigger than the call.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/