linux-kernel - Re: [PATCH 1/5] signal(x86_32): Improve the signal stack overflow check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <26325.1203357921@turing-police.cc.vt.edu>
Date:	Mon, 18 Feb 2008 13:05:21 -0500
From:	Valdis.Kletnieks@...edu
To:	Shi Weihua <shiwh@...fujitsu.com>
Cc:	Ingo Molnar <mingo@...e.hu>, linux-kernel@...r.kernel.org,
	Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>
Subject: Re: [PATCH 1/5] signal(x86_32): Improve the signal stack overflow check

On Mon, 18 Feb 2008 18:22:05 +0800, Shi Weihua said:

> -	/*
> -	 * If we are on the alternate signal stack and would overflow it, don't.
                                                                   notice this ^
> -	 * Return an always-bogus address instead so we will die with SIGSEGV.

> +			 * If we are on the alternate signal stack and would
> +			 * overflow it, don't return an always-bogus address
                                missing here ^
> +			 * instead so we will die with SIGSEGV.

"don't. Return" is a vastly different semantic than "don't return".

I think the same comment error was cut-n-pasted into all 5 patches...


Content of type "application/pgp-signature" skipped