linux-kernel - [2.6.22.y #2] quicklists: Only consider memory that can be used with GFP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <6101e8c40802181201o4e997b4w1525281ec93072e1@mail.gmail.com>
Date:	Mon, 18 Feb 2008 21:01:11 +0100
From:	"Oliver Pinter" <oliver.pntr@...il.com>
To:	"Linux Kernel" <linux-kernel@...r.kernel.org>, stable@...nel.org,
	stable-commits@...r.kernel.org
Cc:	"Oliver Pinter" <oliver.pntr@...il.com>,
	"Adrian Bunk" <bunk@...nel.org>, "Greg KH" <gregkh@...e.de>,
	"Justin Forbes" <jmforbes@...uxtx.org>,
	"Zwane Mwaikambo" <zwane@....linux.org.uk>,
	"Theodore Ts'o" <tytso@....edu>,
	"Randy. Dunlap" <rdunlap@...otime.net>,
	"Chuck Wolber" <chuckw@...ntumlinux.com>,
	"Dave Jones" <davej@...hat.com>,
	"Chris Wedgwood" <reviews@...cw.f00f.org>,
	"Michael Krufky" <mkrufky@...uxtv.org>,
	"Chuck Ebbert" <cebbert@...hat.com>,
	"Domenico Andreoli" <cavokz@...il.com>,
	"Christoph Lameter" <clameter@....com>,
	"Dhaval Giani" <dhaval@...ux.vnet.ibm.com>,
	"Andrew Morton" <akpm@...ux-foundation.org>,
	"chrisw@...s-sol.org" <chrisw@...s-sol.org>
Subject: [2.6.22.y #2] quicklists: Only consider memory that can be used with GFP_KERNEL

 From fcae8056673aa7b5b55d669fe5255ae76a93ae53 Mon Sep 17 00:00:00 2001
 From: Christoph Lameter <clameter@....com>
 Date: Wed, 16 Jan 2008 00:21:19 +0530
 Subject: [PATCH] quicklists: Only consider memory that can be used
 with GFP_KERNEL
 
 patch 96990a4ae979df9e235d01097d6175759331e88c in mainline.
 
 Quicklists calculates the size of the quicklists based on the number of
 free pages.  This must be the number of free pages that can be allocated
 with GFP_KERNEL.  node_page_state() includes the pages in ZONE_HIGHMEM and
 ZONE_MOVABLE which may lead the quicklists to become too large causing OOM.
 
 Signed-off-by: Christoph Lameter <clameter@....com>
 Tested-by: Dhaval Giani <dhaval@...ux.vnet.ibm.com>
 Signed-off-by: Andrew Morton <akpm@...ux-foundation.org>
 Signed-off-by: Linus Torvalds <torvalds@...ux-foundation.org>
 Signed-off-by: Greg Kroah-Hartman <gregkh@...e.de>
 Signed-off-by: Oliver Pinter <oliver.pntr@...il.com>
 
 diff --git a/mm/quicklist.c b/mm/quicklist.c
 index ae8189c..3f703f7 100644
 --- a/mm/quicklist.c
 +++ b/mm/quicklist.c
 @@ -26,9 +26,17 @@ DEFINE_PER_CPU(struct quicklist,
 quicklist)[CONFIG_NR_QUICK];
  static unsigned long max_pages(unsigned long min_pages)
  {
  	unsigned long node_free_pages, max;
 +	struct zone *zones = NODE_DATA(numa_node_id())->node_zones;
 +
 +	node_free_pages =
 +#ifdef CONFIG_ZONE_DMA
 +		zone_page_state(&zones[ZONE_DMA], NR_FREE_PAGES) +
 +#endif
 +#ifdef CONFIG_ZONE_DMA32
 +		zone_page_state(&zones[ZONE_DMA32], NR_FREE_PAGES) +
 +#endif
 +		zone_page_state(&zones[ZONE_NORMAL], NR_FREE_PAGES);
 
 -	node_free_pages = node_page_state(numa_node_id(),
 -			NR_FREE_PAGES);
  	max = node_free_pages / FRACTION_OF_NODE_MEM;
  	return max(max, min_pages);
  }
 
 
 -- 
 Thanks,
 Oliver
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/