linux-kernel - Re: [lm-sensors] [PATCH] adt7473: New driver for Analog Devices ADT7473 sensor chip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 18 Feb 2008 13:32:34 -0800
From:	"Darrick J. Wong" <djwong@...ibm.com>
To:	"Mark M. Hoffman" <mhoffman@...htlink.com>
Cc:	Jean Delvare <khali@...ux-fr.org>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	lm-sensors <lm-sensors@...sensors.org>
Subject: Re: [lm-sensors] [PATCH] adt7473: New driver for Analog Devices
	ADT7473 sensor chip

On Sun, Feb 17, 2008 at 03:02:50PM -0500, Mark M. Hoffman wrote:

> Documentation/hwmon/adt7473 would be nice.

Ok, I'll generate one.

> That should be const.

Applied.

> > +	BUG();
> 
> Given ADT7473_PWM_BHVR_SHIFT is 5, this BUG() is obviously impossible.
> But I guess it's not obvious to GCC.

I'll put in a comment to explain that.

> NACK on that comment and associated code:  Jean Delvare submitted a
> patch to NVIDIA over two years ago to fix their bug.  Apparently some
> distros even carry his patch.  So, I don't want to encourage such a
> hack to persist.  Please just do the standard check here.

Ok.  I wonder if the nouveau people have any intention to
reverse-engineer the i2c controller?

Updated patch to follow soon.

--D
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/