linux-kernel - Re: [PATCH] snd-hda-intel: don't print using snd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <s5hpruuvjz0.wl%tiwai@suse.de>
Date:	Mon, 18 Feb 2008 07:48:03 +0100
From:	Takashi Iwai <tiwai@...e.de>
To:	Chuck Ebbert <cebbert@...hat.com>
Cc:	Adel Gadllah <adel.gadllah@...il.com>,
	kernel list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] snd-hda-intel: don't print using snd_printdd on device open

At Sun, 17 Feb 2008 21:40:32 -0500,
Chuck Ebbert wrote:
> 
> From: Adel Gadllah <adel.gadllah@...il.com>
> 
> snd-hda-intel: don't print using snd_printdd on device open
> 
> When CONFIG_SND_DEBUG_DETECT is set the hda-intel driver prints verbose
> info like this:
> 
> ALSA sound/pci/hda/hda_intel.c:1259: azx_pcm_prepare: bufsize=0x4400,
> fragsize=0x1100, format=0x11
> ALSA sound/pci/hda/hda_codec.c:682: hda_codec_setup_stream: NID=0x7,
> stream=0x5, channel=0, format=0x11
> ALSA sound/pci/hda/hda_codec.c:682: hda_codec_setup_stream: NID=0x3,
> stream=0x5, channel=0, format=0x11
> ALSA sound/pci/hda/hda_codec.c:682: hda_codec_setup_stream: NID=0x3,
> stream=0x0, channel=0, format=0x0
> ALSA sound/pci/hda/hda_codec.c:682: hda_codec_setup_stream: NID=0x7,
> stream=0x0, channel=0, format=0x0
> ALSA sound/pci/hda/hda_codec.c:682: hda_codec_setup_stream: NID=0x3,
> stream=0x0, channel=0, format=0x0
> 
> Don't print anything in functions that get called when the device gets
> opened/prepared for output.

Why?  This debug option is explicitly for debugging purposes, and I
see no reason why such behavior is prohibited.


Takashi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/