linux-kernel - Re: [PATCH] x86: define outb_pic and inb_pic to stop using outb_p and inb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080219094256.GC7628@elte.hu>
Date:	Tue, 19 Feb 2008 10:42:56 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	"David P. Reed" <dpreed@...d.com>
Cc:	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>,
	Alan Cox <alan@...rguk.ukuu.org.uk>,
	Rene Herman <rene.herman@...access.nl>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86: define outb_pic and inb_pic to stop using outb_p
	and inb_p


* David P. Reed <dpreed@...d.com> wrote:

> x86: define outb_pic and inb_pic to stop using outb_p and inb_p
>  
> The delay between io port accesses to the PIC is now defined using 
> outb_pic and inb_pic.  This fix provides the next step, using 
> udelay(2) to define the *PIC specific* timing requirements, rather 
> than on bus-oriented timing, which is not well calibrated.

thanks David, applied.

minor nit:

> +	/* delay for some accesses to PIC on motherboard or in chipset must be
> +	   at least one microsecond, but be safe here. */

i changed this to the standard multi-line comment style of:

> +	/*
> +      * Delay for some accesses to PIC on motherboard or in chipset 
> +      * must be at least one microsecond, but be safe here:
> +      */

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/