linux-kernel - [BUG][RFC][GENERIC IRQ] linux-2.6.24 (delayed) disable IRQ feature not functional for handle_simple

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <600D5CB4DFD93545BF61FF01473D11AC125CCE48@limkexm2.ad.analog.com>
Date:	Tue, 19 Feb 2008 10:25:13 -0000
From:	"Hennerich, Michael" <Michael.Hennerich@...log.com>
To:	"Thomas Gleixner" <tglx@...utronix.de>,
	"Hennerich, Michael" <Michael.Hennerich@...log.com>
Cc:	<mingo@...e.hu>, <linux-kernel@...r.kernel.org>
Subject: [BUG][RFC][GENERIC IRQ] linux-2.6.24 (delayed) disable IRQ feature not functional for handle_simple_irq

Thomas,

I have reasonable doubt that the delayed disable feature on linux-2.6.24 for handle_simple_irq is broken.

In 2.6.22 there was something like this:

	if (unlikely(!action || (desc->status & IRQ_DISABLED))) {
		if (desc->chip->mask)
			desc->chip->mask(irq);
...

However in 2.6.24 the "DISABLED" IRQ in case it happens is never going to be masked.  

	if (unlikely(!action || (desc->status & IRQ_DISABLED)))
		goto out_unlock;


I see a disabled IRQ being invoked in an endless loop.

-Michael

------------------------------------------------------------------
********* Analog Devices GmbH         michael.hennerich@...log.com
**  *****                                      Systems Engineering
**     ** Wilhelm-Wagenfeld-Strasse 6       
**  ***** D-80807 Munich                      
********* Germany                          
Registergericht München HRB 40368,  Geschäftsführer:  Thomas Wessel,  Vincent Roche,  Joseph E. McDonough 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/