linux-kernel - Re: [PATCH 03/12] ide: add ide-4drives host driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 19 Feb 2008 22:24:35 +0100
From:	Bartlomiej Zolnierkiewicz <bzolnier@...il.com>
To:	Sergei Shtylyov <sshtylyov@...mvista.com>
Cc:	linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 03/12] ide: add ide-4drives host driver

On Tuesday 19 February 2008, Sergei Shtylyov wrote:
> Bartlomiej Zolnierkiewicz wrote:
> 
> > CONFIG_BLK_DEV_4DRIVES deserves its own host driver:
> 
> > * Add drivers/ide/legacy/ide-4drives.c and move "4drives" support there.
> 
> > * Add ide-4drives.o in the link order after all other legacy host
> >   drivers enabled by "ide0=" options (they all are mutually exclusive).
> 
> > * Make ide-4drives host driver probe itself for IDE devices instead of
> >   indirectly depending on ide_generic host driver.
> 
> > * Add "probe" module parameter to ide-4drives and update documentation.
> 
> > Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@...il.com>
> 
> > Index: b/drivers/ide/Kconfig
> > ===================================================================
> > --- a/drivers/ide/Kconfig
> > +++ b/drivers/ide/Kconfig
> > @@ -1042,8 +1042,8 @@ config BLK_DEV_4DRIVES
> >  	  Certain older chipsets, including the Tekram 690CD, use a single set
> >  	  of I/O ports at 0x1f0 to control up to four drives, instead of the
> >  	  customary two drives per port. Support for this can be enabled at
> > -	  runtime using the "ide0=four" kernel boot parameter if you say Y
> > -	  here.
> > +	  runtime using the "ide_4drives.probe" kernel boot parameter if you
> 
>     Not "ide-4drives.probe?
>     Looks correct otherwise.

I believe that both versions are correct but I fixed this in 'take 3' to
be on the safe side.

Thanks,
Bart
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/