[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <47BB594E.1050103@rtr.ca>
Date: Tue, 19 Feb 2008 17:33:50 -0500
From: Mark Lord <lkml@....ca>
To: Paulo Marques <pmarques@...popie.com>
Cc: Theodore Tso <tytso@....edu>, Andi Kleen <andi@...stfloor.org>,
Tomasz Chmielewski <mangoo@...g.org>,
LKML <linux-fsdevel@...r.kernel.org>,
LKML <linux-kernel@...r.kernel.org>
Subject: Re: very poor ext3 write performance on big filesystems?
Paulo Marques wrote:
> Mark Lord wrote:
>> Theodore Tso wrote:
>> ..
>>> The following ld_preload can help in some cases. Mutt has this hack
>>> encoded in for maildir directories, which helps.
>> ..
>>
>> Oddly enough, that same spd_readdir() preload craps out here too
>> when used with "rm -r" on largish directories.
>
> From looking at the code, I think I've found at least one bug in opendir:
> ...
>> dnew = realloc(dirstruct->dp,
>> dirstruct->max * sizeof(struct dir_s));
> ...
>
> Shouldn't this be: "...*sizeof(struct dirent_s));"?
..
Yeah, that's one bug.
Another is that ->fd is frequently left uninitialized, yet later used.
Fixing those didn't change the null pointer deaths, though.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists