[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20080219152129.6e8b7956.akpm@linux-foundation.org>
Date: Tue, 19 Feb 2008 15:21:29 -0800
From: Andrew Morton <akpm@...ux-foundation.org>
To: Thomas Petazzoni <thomas.petazzoni@...e-electrons.com>
Cc: Randy Dunlap <randy.dunlap@...cle.com>,
linux-kernel@...r.kernel.org, len.brown@...el.com,
linux-acpi@...r.kernel.org, michael@...e-electrons.com
Subject: Re: 2.6.25-rc2-mm1 (x64 thermal build failure)
On Tue, 19 Feb 2008 16:55:02 +0100 Thomas Petazzoni <thomas.petazzoni@...e-electrons.com> wrote:
> Le Mon, 18 Feb 2008 04:13:40 -0800,
> Andrew Morton <akpm@...ux-foundation.org> a __crit :
>
> > Option 3 wold be to add more #ifdef CONFIG_DMI lines around the
> > place. How ugly would that get?
>
> Like the attached patch. #ifdef CONFIG_DMI everywhere :-(
>
ug, sorry, if I'd realised it was like this I'd have said "don't bother".
Apart from the obvious problem, this means that people will keep breaking
CONFIG_DMI=n all the time, because they will forget the ifdefs, and the
number of people who test with CONFIG_DMI=n will be small.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists