linux-kernel - Re: [PATCH] Fix building lguest as module.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080219233520.GB6887@bakeyournoodle.com>
Date:	Wed, 20 Feb 2008 10:35:21 +1100
From:	tony@...eyournoodle.com (Tony Breeds)
To:	Ingo Molnar <mingo@...e.hu>
Cc:	Rusty Russell <rusty@...tcorp.com.au>,
	linux-kernel@...r.kernel.org,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	lguest@...abs.org
Subject: Re: [PATCH] Fix building lguest as module.

On Tue, Feb 19, 2008 at 02:54:01PM +0100, Ingo Molnar wrote:
> 
> * Ingo Molnar <mingo@...e.hu> wrote:
> 
> > > +#endif
> > > +
> > > +#if defined(CONFIG_LGUEST) || defined(CONFIG_LGUEST_MODULE)
> > > +	BLANK();
> > 
> > hm. Rusty's original fix is now upstream. I've done a delta to your 
> > patch, find the fix is below.

Thanks!.
> 
> the right one is below. There's no 'LGUEST_MODULE' anymore - 
> 'LGUEST_GUEST' is what should be used.

Hmm okay I'm confused now.  LGUEST_GUEST is only set when you have guest
support enabled, but if you're only building the host module[1] then that wont
work.

Appologies if I've missed soemthing.

-=-=-=-=-=-=-=-=-=-=-=-
tony@...r:~/projects/kernel/working$ git describe
v2.6.25-rc2-103-gf702c58
tony@...r:~/projects/kernel/working$ egrep LGUEST /scratch/tmp/include/linux/autoconf.h
#define CONFIG_LGUEST_MODULE 1
tony@...r:~/projects/kernel/working$ egrep 'defined.*CONFIG_LGUEST' arch/x86/kernel/asm-offsets_32.c 
#if defined(CONFIG_LGUEST) || defined(CONFIG_LGUEST_GUEST)
tony@...r:~/projects/kernel/working$ make O=/scratch/tmp -s
  GEN     /scratch/tmp/Makefile
  Using /home/tony/projects/kernel/working as source for kernel
WARNING: modpost: Found 33 section mismatch(es).
To see full details build your kernel with:
'make CONFIG_DEBUG_SECTION_MISMATCH=y'
  UPD     include/linux/compile.h
  Building modules, stage 2.
ERROR: "LGUEST_PAGES_guest_gdt_desc" [drivers/lguest/lg.ko] undefined!
ERROR: "LGUEST_PAGES_host_gdt_desc" [drivers/lguest/lg.ko] undefined!
ERROR: "LGUEST_PAGES_host_cr3" [drivers/lguest/lg.ko] undefined!
ERROR: "LGUEST_PAGES_regs" [drivers/lguest/lg.ko] undefined!
ERROR: "LGUEST_PAGES_host_idt_desc" [drivers/lguest/lg.ko] undefined!
ERROR: "LGUEST_PAGES_guest_gdt" [drivers/lguest/lg.ko] undefined!
ERROR: "LGUEST_PAGES_host_sp" [drivers/lguest/lg.ko] undefined!
ERROR: "LGUEST_PAGES_regs_trapnum" [drivers/lguest/lg.ko] undefined!
ERROR: "LGUEST_PAGES_guest_idt_desc" [drivers/lguest/lg.ko] undefined!
make[2]: *** [__modpost] Error 1
make[1]: *** [modules] Error 2
make[1]: *** Waiting for unfinished jobs....
Root device is (3, 3)
Setup is 11320 bytes (padded to 11776 bytes).
System is 2663 kB
Kernel: arch/x86/boot/bzImage is ready  (#17)
make: *** [sub-make] Error 2
-=-=-=-=-=-=-=-=-=-=-=-
tony@...r:~/projects/kernel/working$ egrep LGUEST /scratch/tmp/include/linux/autoconf.h
#define CONFIG_LGUEST_MODULE 1
tony@...r:~/projects/kernel/working$ egrep 'defined.*CONFIG_LGUEST' arch/x86/kernel/asm-offsets_32.c 
#if defined(CONFIG_LGUEST) || defined(CONFIG_LGUEST_MODULE)
tony@...r:~/projects/kernel/working$ make O=/scratch/tmp -s
  GEN     /scratch/tmp/Makefile
  Using /home/tony/projects/kernel/working as source for kernel
WARNING: modpost: Found 33 section mismatch(es).
To see full details build your kernel with:
'make CONFIG_DEBUG_SECTION_MISMATCH=y'
  UPD     include/linux/compile.h
  Building modules, stage 2.
Root device is (3, 3)
Setup is 11320 bytes (padded to 11776 bytes).
System is 2663 kB
Kernel: arch/x86/boot/bzImage is ready  (#18)

I've attached the .config FWIW

[1] Somewhat strange I agree but valid none the less.

Yours Tony

  linux.conf.au        http://linux.conf.au/ || http://lca2008.linux.org.au/
  Jan 28 - Feb 02 2008 The Australian Linux Technical Conference!


View attachment "config-lguest" of type "text/plain" (39476 bytes)