linux-kernel - Re: arch/x86/kernel/acpi/sleep

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200802200041.47851.rjw@sisk.pl>
Date:	Wed, 20 Feb 2008 00:41:46 +0100
From:	"Rafael J. Wysocki" <rjw@...k.pl>
To:	Pavel Machek <pavel@....cz>
Cc:	Thomas Petazzoni <thomas.petazzoni@...x.org>, tglx@...utronix.de,
	mingo@...hat.com, hpa@...or.com, linux-kernel@...r.kernel.org,
	pm list <linux-pm@...ts.linux-foundation.org>
Subject: Re: arch/x86/kernel/acpi/sleep_32.c not compiled ?

On Tuesday, 19 of February 2008, Pavel Machek wrote:
> On Tue 2008-02-19 22:02:52, Rafael J. Wysocki wrote:
> > On Tuesday, 19 of February 2008, Thomas Petazzoni wrote:
> > > Hi,
> > 
> > Hi,
> > 
> > > Maybe I'm missing something completely obvious, but I don't see where
> > > the arch/x86/kernel/acpi/sleep_32.c file gets compiled. The Makefile in
> > > that directory compiles sleep.o, but doesn't compile sleep_$(BITS).o:
> > > 
> > > obj-$(CONFIG_ACPI)              += boot.o
> > > obj-$(CONFIG_ACPI_SLEEP)        += sleep.o wakeup_$(BITS).o
> > > 
> > > ifneq ($(CONFIG_ACPI_PROCESSOR),)
> > > obj-y                           += cstate.o processor.o
> > > endif
> > 
> > No, the file is not build now.
> > 
> > Pavel, is this file really necessary?
> 
> sleep_32.c is obsolete. It tried to do s2ram whitelist in kernel, with
> just one entry ;-). Remove it. If Mirek Spousta (probably last
> remaining owner of whitelisted toshiba, he got it from me ;-)
> complains, I'll give him better machine or something.

Well, then perhaps we also should remove the S1 quirk for the same box from
drivers/acpi/sleep/main.c ?

Alternatively, put them both into the same file and simplify things (in which
case I'd vote for drivers/acpi/sleep/main.c)?

Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/