linux-kernel - Re: [patch] sysfs: small header file cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 19 Feb 2008 20:17:20 -0800
From:	Randy Dunlap <randy.dunlap@...cle.com>
To:	David Rientjes <rientjes@...gle.com>
CC:	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [patch] sysfs: small header file cleanup

David Rientjes wrote:
> Convert sysfs_remove_bin_file() to have a return type of 'void' for
> !CONFIG_SYSFS configurations.  Also removes unnecessary colons from empty
> void functions.
> 
> Cc: Randy Dunlap <randy.dunlap@...cle.com>

Reviewed-by: Randy Dunlap <randy.dunlap@...cle.com>

Thanks, David.

> Signed-off-by: David Rientjes <rientjes@...gle.com>
> ---
>  include/linux/sysfs.h |    9 ++-------
>  1 files changed, 2 insertions(+), 7 deletions(-)
> 
> diff --git a/include/linux/sysfs.h b/include/linux/sysfs.h
> --- a/include/linux/sysfs.h
> +++ b/include/linux/sysfs.h
> @@ -131,7 +131,6 @@ static inline int sysfs_create_dir(struct kobject *kobj)
>  
>  static inline void sysfs_remove_dir(struct kobject *kobj)
>  {
> -	;
>  }
>  
>  static inline int sysfs_rename_dir(struct kobject *kobj, const char *new_name)
> @@ -160,7 +159,6 @@ static inline int sysfs_chmod_file(struct kobject *kobj,
>  static inline void sysfs_remove_file(struct kobject *kobj,
>  				     const struct attribute *attr)
>  {
> -	;
>  }
>  
>  static inline int sysfs_create_bin_file(struct kobject *kobj,
> @@ -169,10 +167,9 @@ static inline int sysfs_create_bin_file(struct kobject *kobj,
>  	return 0;
>  }
>  
> -static inline int sysfs_remove_bin_file(struct kobject *kobj,
> -					struct bin_attribute *attr)
> +static inline void sysfs_remove_bin_file(struct kobject *kobj,
> +					 struct bin_attribute *attr)
>  {
> -	return 0;
>  }
>  
>  static inline int sysfs_create_link(struct kobject *kobj,
> @@ -183,7 +180,6 @@ static inline int sysfs_create_link(struct kobject *kobj,
>  
>  static inline void sysfs_remove_link(struct kobject *kobj, const char *name)
>  {
> -	;
>  }
>  
>  static inline int sysfs_create_group(struct kobject *kobj,
> @@ -195,7 +191,6 @@ static inline int sysfs_create_group(struct kobject *kobj,
>  static inline void sysfs_remove_group(struct kobject *kobj,
>  				      const struct attribute_group *grp)
>  {
> -	;
>  }
>  
>  static inline int sysfs_add_file_to_group(struct kobject *kobj,


-- 
~Randy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/